Split ConsoleKit into two functional targets #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
added
the
semver-minor
MahdiBM
requested changes
Nov 13, 2023
0xTim
approved these changes
Nov 13, 2023
| @@ -16,7 +16,6 @@ struct AsyncExample { | |||
| try await console.run(group, input: input) | |||
| } catch let error { | |||
| console.error("\(error)") | |||
| exit(1) | |||
There was a problem hiding this comment.
'cause it had no meaningful effect, and exiting with a nonzero status is arguably a questionable behavior to provide as an example (especially when exit(1) isn't a fully platform-agnostic or even necessarily correct means of doing so)
ptoffy
approved these changes
Nov 14, 2023
MahdiBM
approved these changes
Nov 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 49.28% 48.61% -0.68%
==========================================
Files 45 44 -1
Lines 1901 1874 -27
==========================================
- Hits 937 911 -26
+ Misses 964 963 -1
|
…action, one for command handling, plus an umbrella for compatibility. Also update README, and docs images. Clean up several bits of code.
Co-authored-by: Mahdi Bahrami <github@mahdibm.com> Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
…sons learned from apple/swift-argument-parser#590, pretty much just for the hell of it. Deprecate `ConsoleErrror`.
|
These changes are now available in 4.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsoleKit has been split into two separate targets:
ConsoleKitTerminalcontains the logic for interacting with a console (I/O, color support, other ANSI commands, etc.).ConsoleKitCommandscontains the functionality for handling argument parsing, which is now soft-deprecated in favor ofswift-argument-parserwhen possible.The existing
ConsoleKittarget is now an umbrella import, similar to the function of theNIOtarget inswift-nio; existing code should be unaffected.Several additional minor cleanups were also made in the process of this split.